-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Build with Homebrew-provided Vulkan dependencies #621
Comments
I've been working on this. A change to Homebrew will be required as they are currently building shaderc without FindVulkan is going away upstream as well, so I'm eliminating the use of its functionality from scopehal / scopehal-apps proper; VkFFT still uses it though. |
Nice. Not sure if you saw the formula I had in the expandable part of the first post, but it's a good starting point. |
Fixed in #673. |
I built
Does that look right? I'm not sure about runtime vs build time dependencies. The formula ideally works on Linux too, but I haven't tried it. |
@azonenberg At this point we can pretty much submit this to Homebrew, but I can already predict they'd prefer you tagged a release rather than always installing from |
@rgov would you like to PR your formula to https://github.com/ngscopeclient/homebrew-ngscopeclient, or should I add it? |
Ready for review: ngscopeclient/homebrew-ngscopeclient#1 |
The build instructions for macOS call for some dependencies to be installed from Homebrew formulae and others to come from the LunarG VulkanSDK.
There are also brew formulae for many components of the VulkanSDK. Just grepping for formulae from the KhronosGroup GitHub organization:
However I am unsure which VulkanSDK components are actually needed to build ngscopeclient. Could you please clarify?
Using the dependencies from Homebrew is likely a requirement to have an install formula for ngscopeclient accepted upstream.
Homebrew formula
ngscopeclient/homebrew-ngscopeclient#1
The text was updated successfully, but these errors were encountered: