Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: make CHANNEL_TYPE_x a property of the stream rather than a channel #572

Closed
azonenberg opened this issue Mar 27, 2022 · 1 comment
Closed

Refactoring: make CHANNEL_TYPE_x a property of the stream rather than a channel #572

azonenberg opened this issue Mar 27, 2022 · 1 comment
Labels
api API improvements cleanup Removing cruft core
Milestone
v0.1

Comments

@azonenberg
Copy link
Collaborator

This allows import filters to output both analog and digital data
@azonenberg azonenberg added api API improvements cleanup Removing cruft core labels Mar 27, 2022
@azonenberg
Copy link
Collaborator Author

Alternatively: delete channel type entirely and rely on dynamic_cast of the waveform? but this won't work if we have no waveform to display...

This was referenced Jun 3, 2022
Closed
Closed
@azonenberg azonenberg added this to the v0.1 milestone Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api API improvements cleanup Removing cruft core
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
1 participant
@azonenberg