nghttp3: error building from tagged release archive 1.2.0 for OpenWrt

[stangri]

Hello @tatsuhiro-t @vszakats,

I'm building from last tagged release 1.2.0 and the unpacked source files do not include neither sfparse/, nor munit/, so the build fails with:

-- Configuring done (1.3s)
CMake Error at lib/CMakeLists.txt:68 (add_library):
  Cannot find source file:

    sfparse/sfparse.c


CMake Error at tests/CMakeLists.txt:44 (add_executable):
  Cannot find source file:

    munit/munit.c

Should the tagged release not include those? Am I doing something wrong?

Thanks!

[tatsuhiro-t]

Please read the release note
https://github.com/ngtcp2/nghttp3/releases/tag/v1.2.0

[stangri]

Please read the release note https://github.com/ngtcp2/nghttp3/releases/tag/v1.2.0

The release note states Run git submodule update --init before building from git.. I am NOT building from git, I'm building from unpacked tagged release archive (https://github.com/ngtcp2/nghttp3/releases/download/v1.2.0/nghttp3-1.2.0.tar.gz) as recommended for package maintainers for OpenWrt. It is not a git repo, it's a directory of files which does not include dependencies.

Can you help me understand how can I build from tagged release archive?

[tatsuhiro-t]

Tar archives should include sfparse and munit files. I just downloaded one of them and successfully built nghttp3 with cmake.

$ tar tf nghttp3-1.2.0.tar.bz2 | grep 'sfparse\|munit'
nghttp3-1.2.0/tests/munit/
nghttp3-1.2.0/tests/munit/COPYING
nghttp3-1.2.0/tests/munit/munit.c
nghttp3-1.2.0/tests/munit/munit.h
nghttp3-1.2.0/lib/sfparse/
nghttp3-1.2.0/lib/sfparse/COPYING
nghttp3-1.2.0/lib/sfparse/sfparse.c
nghttp3-1.2.0/lib/sfparse/sfparse.h

[stangri]

You're right, my bad, the directories are there, I'll try to figure out why I get the errors building and update the issue.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[BKPepe]

Steps to reproduce what @stangri reported:

Provided tarballs from GitHub:

1. Go to https://github.com/ngtcp2/nghttp3/releases/tag/v1.2.0
2. Click on Source code (tar.gz), download it.
3. Extract it
4. Files are not there.

On the other hand, provided tarballs from you have them:

1. Instead of downloading Source code (tar.gz), I downloaded nghttp3-1.2.0.tar.gz and that tarball have the files, which it should have.

In any case, you should look into it.

[tatsuhiro-t]

Do not use the tar ball generated by github automatically. Download the signed tar ball such as nghttp2-1.2.0.tar.gz.
If I can disable the auto-generated tar balls, I will do it, but it seems github does not offer such option.

[BKPepe]

The issue is even elsewhere than we both thought. The issue should be: provided GitHub tarballs do not include submodules, while looking into it further, I realized that you are not the only one dealing with the issue and other projects have the issue like you do. :-(

E.g. dear-github/dear-github#214

However, it is still regression because, in older versions than 1.2.0, we were able to use the auto-generated tarball. In any case, there should be some warning that people should use your tarball instead of those automated ones.

At least we found out that culprit.

It seems github does not offer such option.

Yep, that's correct, according to https://github.com/orgs/community/discussions/6003

//EDIT: This issue is duplicate of #203

[stangri]

I've managed to overcome this by using tagged release, closing.