Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfolding stops at 0 #178

Open
pfhein opened this issue Jan 26, 2017 · 4 comments
Open

Unfolding stops at 0 #178

pfhein opened this issue Jan 26, 2017 · 4 comments

Comments

@pfhein
Copy link

pfhein commented Jan 26, 2017

I have seen a case where the unfolding/deliasing stops at zero velocity. The velocity is large enough that is wraps around and goes past the 0m/s mark. but the unfolding does not catch it.

@gamaanderson
Copy link
Contributor

isn't this a pyart issue?

for reference the desiasing is done either with:
pyart.correct.dealias_region_based(radar, gatefilter)
pyart.correct.dealias_unwrap_phase(radar, gatefilter)
depending on which plugin you are using

if you are talking about the manual unfold, such a case can not be corrected with that simple of an algorithm, I recommend using the pyart methods before.

@pfhein
Copy link
Author

pfhein commented Jan 27, 2017

Yes, this is manual unfolding/deliasing so not the automatic dealiasing of pyart. You are right about it not being possible to cross the 0 line since that would make it harder to distinguish between those points that do not need to be dealiased and those points that do. A simple algorithm does not make it possible.

Here are two plots. One before the dealiasing and one after. The dealiasing happens in the upper right quadrant of the plot.
Before dealiasing
before_unfolding
And the after dealiasing
unfolded_once
You can see that the discontinuity remains but it was shifted to the zero m/s contour.

@gamaanderson
Copy link
Contributor

I'm not really sure how we can solve this, since as you said the zero line is what is being used to separate what need dealing and what does not. We could allow the user to change this threshold value, but I'm not sure about that. We could also add a component to do a linear transformation in a selected region + gatefilter, that would probably be much more difficult to work with, but gives you full control.

Let me know what you think and we may add as a to do, and it will hopefully be addressed at some time. Also if you want to do it your self I would be glad to give directions.

@gamaanderson
Copy link
Contributor

by the way @pfhein I'm planning to be presenting ARTView in the AMS's 38th Conference, on august. If you have any thoughts I would be glad to hear, send me an e-mail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants