Skip to content
This repository has been archived by the owner on Mar 12, 2023. It is now read-only.

[BUG] - binding.pry #39

Closed
scottbarrow opened this issue Sep 14, 2020 · 1 comment · Fixed by #41
Closed

[BUG] - binding.pry #39

scottbarrow opened this issue Sep 14, 2020 · 1 comment · Fixed by #41
Labels
bug Something isn't working released The issue is resolved with the newest release

Comments

@scottbarrow
Copy link

Describe the bug
Expected binding.pry to work as it does with pry, pry-rails, pry-debugger since pry is a dependency of this gem.
It would be great if Jard was backwards compatible so that users who prefer binding.pry can use it alongside other team members wishing to use Jard

To Reproduce
Steps to reproduce the behavior:

  1. Use binding.pry in a file

Expected behavior
Pry to work as it previously did

Screenshots

before_session hook failed: UncaughtThrowError: uncaught throw :jard_control_flow
/Users/scott/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/bundler/gems/ruby_jard-c794d14072ed/lib/ruby_jard/control_flow.rb:53:in `throw'
@scottbarrow scottbarrow added the bug Something isn't working label Sep 14, 2020
@0x2c7 0x2c7 closed this as completed in #41 Sep 15, 2020
@0x2c7
Copy link
Owner

0x2c7 commented Sep 15, 2020

This issue is fixed in #41. You can now use one of binding.pry, byebug, debugger, jard commands depending your preference. The limitation is that after jard is first triggered, the backward compatibility is not guranteed anymore. The reason is that after Jard starts, it takes over internal states of Pry and Byebug. So, byebug and pry are not awared of external changes, and won't work as expected. If Jard doesn't start, they are fine.

def test
  jard
  sleep 0
  byebug # It triggers jard interfaces
  sleep 0
  binding.pry # Broken
end

@0x2c7 0x2c7 added wait for release released The issue is resolved with the newest release and removed wait for release labels Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released The issue is resolved with the newest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants