This repository has been archived by the owner on Mar 12, 2023. It is now read-only.
Cover more edge cases when resize window #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x2c7
force-pushed
the
bug/control-command-is-empty
branch
from
fbc0f62
to
4bcd05e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent implementation, whenever the window is resized, a control flow event is raised, and captured by outsider, and redraw the screen. There are known issues:
resize eventerror, and crash the process ([BUG] Control command is empty #70)So, it's better to defer the resizing event to whenever REPL session is idle. However, at that time, if there is any output printed out during the evaluation, the users may not see it as the screen is refresh. therefore, I decided to replay the output into the screen after resizing is done.
