Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 hour flight cannot be saved #73

Closed
4 tasks done
nguyenquyhy opened this issue Apr 6, 2021 · 1 comment
Closed
4 tasks done

8 hour flight cannot be saved #73

nguyenquyhy opened this issue Apr 6, 2021 · 1 comment
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@nguyenquyhy
Copy link
Owner

nguyenquyhy commented Apr 6, 2021

Flight over the Atlantic From JFK to Sweden hangs when i try to save for example. 8 hours. Shorter flights for exemple Stockholm-Copenhagen works fine.

Investigation: Serialize/Deserialize a large list into string take a really long time and can lead to OOM. A better way would be to do that directly on stream.

  • Async for saving and loading
  • Add Saving & Loading states and disable controls appropriately
  • Handle reverting back to correct state on error
  • Handle exiting
@nguyenquyhy nguyenquyhy added the bug Something isn't working label Apr 6, 2021
@nguyenquyhy nguyenquyhy added this to the 0.14 milestone Apr 6, 2021
@nguyenquyhy nguyenquyhy added enhancement New feature or request pending-release and removed pending-release labels Apr 9, 2021
@nguyenquyhy
Copy link
Owner Author

Released in v0.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant