fix(core): include field without key on hide changed programmatically (…

…#1904)
ngx-formly · Nov 6, 2019 · 39a9051 · 39a9051
1 parent 2d73fb9
commit 39a9051
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/core/src/lib/extensions/field-expression/field-expression.spec.ts b/src/core/src/lib/extensions/field-expression/field-expression.spec.ts
@@ -95,7 +95,7 @@ describe('FieldExpressionExtension', () => {
     it('should toggle field control when hide changed programmatically', () => {
       const fields: FormlyFieldConfig[] = [
         { hide: false, key: 'foo'},
-        { hide: true, key: 'bar'},
+        { hide: true, fieldGroup: [{key: 'bar'}]},
       ];
       builder.buildForm(form, fields, {}, options);
 

diff --git a/src/core/src/lib/extensions/field-expression/field-expression.ts b/src/core/src/lib/extensions/field-expression/field-expression.ts
@@ -75,7 +75,7 @@ export class FieldExpressionExtension implements FormlyExtension {
         field.hideExpression,
         parent && parent.hideExpression ? () => parent.hide : undefined,
       );
-    } else if (field.key) {
+    } else {
       wrapProperty(field, 'hide', ({ currentValue, firstChange }) => {
         if (!firstChange || (firstChange && currentValue === true)) {
           field.options._hiddenFieldsForCheck.push(field);