fix(core): check expressions before emitting modelChange (#1977)

ngx-formly · Dec 13, 2019 · 510570e · 510570e
1 parent f685d3b
commit 510570e
Showing 1 changed file with 1 addition and 10 deletions.
diff --git a/src/core/src/lib/components/formly.form.ts b/src/core/src/lib/components/formly.form.ts
@@ -52,15 +52,6 @@ export class FormlyForm implements DoCheck, OnChanges, OnDestroy {
   private initialModel: any;
   private modelChangeSubs: Subscription[] = [];
 
-  private enableCheckExprDebounce = false;
-  private checkExpressionChange$ = this.modelChange.pipe(
-    debounceTime(this.enableCheckExprDebounce ? 100 : 0),
-  ).subscribe(() => {
-    this.enableCheckExprDebounce = true;
-    this.checkExpressionChange();
-    this.enableCheckExprDebounce = false;
-  });
-
   constructor(
     private formlyBuilder: FormlyFormBuilder,
     private formlyConfig: FormlyConfig,
@@ -94,11 +85,11 @@ export class FormlyForm implements DoCheck, OnChanges, OnDestroy {
 
   ngOnDestroy() {
     this.clearModelSubscriptions();
-    this.checkExpressionChange$.unsubscribe();
   }
 
   changeModel(event: { key: string, value: any }) {
     assignModelValue(this.model, event.key.split('.'), event.value);
+    this.checkExpressionChange();
     this.modelChange.emit(clone(this.model));
   }