fix(material): remove duplicated change event listener (#1649)

fix #1644
ngx-formly · Jul 5, 2019 · d28f7a8 · d28f7a8
1 parent 44535ac
commit d28f7a8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 18 deletions.
diff --git a/src/material/checkbox/src/checkbox.type.ts b/src/material/checkbox/src/checkbox.type.ts
@@ -1,6 +1,6 @@
 import { Component, ViewChild, AfterViewInit, OnDestroy } from '@angular/core';
 import { FieldType } from '@ngx-formly/material/form-field';
-import { MatCheckbox, MatCheckboxChange } from '@angular/material/checkbox';
+import { MatCheckbox } from '@angular/material/checkbox';
 import { FocusMonitor } from '@angular/cdk/a11y';
 
 @Component({
@@ -11,7 +11,6 @@ import { FocusMonitor } from '@angular/cdk/a11y';
       [id]="id"
       [formlyAttributes]="field"
       [tabindex]="to.tabindex || 0"
-      (change)="change($event)"
       [indeterminate]="to.indeterminate && formControl.value === null"
       [color]="to.color"
       [labelPosition]="to.align || to.labelPosition">
@@ -41,12 +40,6 @@ export class FormlyFieldCheckbox extends FieldType implements AfterViewInit, OnD
     super.onContainerClick(event);
   }
 
-  change($event: MatCheckboxChange) {
-    if (this.to.change) {
-      this.to.change(this.field, $event);
-    }
-  }
-
   ngAfterViewInit() {
     super.ngAfterViewInit();
     this.focusMonitor

diff --git a/src/material/radio/src/radio.type.ts b/src/material/radio/src/radio.type.ts
@@ -1,15 +1,14 @@
 import { Component, ViewChild } from '@angular/core';
 import { FieldType } from '@ngx-formly/material/form-field';
-import { MatRadioGroup, MatRadioChange } from '@angular/material/radio';
+import { MatRadioGroup } from '@angular/material/radio';
 
 @Component({
   selector: 'formly-field-mat-radio',
   template: `
     <mat-radio-group
       [formControl]="formControl"
       [formlyAttributes]="field"
-      [tabindex]="to.tabindex || 0"
-      (change)="change($event)">
+      [tabindex]="to.tabindex || 0">
       <mat-radio-button *ngFor="let option of to.options | formlySelectOptions:field | async; let i = index;"
         [id]="id + '_' + i"
         [color]="to.color"
@@ -36,10 +35,4 @@ export class FormlyFieldRadio extends FieldType {
     }
     super.onContainerClick(event);
   }
-
-  change($event: MatRadioChange) {
-    if (this.to.change) {
-      this.to.change(this.field, $event);
-    }
-  }
 }
diff --git a/src/primeng/src/lib/types/checkbox.ts b/src/primeng/src/lib/types/checkbox.ts
@@ -10,7 +10,7 @@ import { FieldType } from '@ngx-formly/core';
       [label]="to.label"
       [formControl]="formControl"
       [formlyAttributes]="field"
-      (valueChange)="to.change && to.change(field, $event)">
+      (onChange)="to.change && to.change(field, $event)">
     </p-checkbox>
   `,
 })