feat(material): add select all option to multiselect #1552
Conversation
|
@aitboudad WIP pull request. The functionality should work as expected. It's just missing some tests. Early feedback welcome 😄. |
juristr
force-pushed
the
feat/multi-select-selectall
branch
from
a0fd4bb
to
5dce775
Compare
| <mat-pseudo-checkbox class="mat-option-pseudo-checkbox" | ||
| [state]="state"> | ||
| </mat-pseudo-checkbox> | ||
| {{ getSelectAllLabel() }} |
There was a problem hiding this comment.
I think we should enforce passing the selectAll label to avoid handling the boolean check, so I propose to use:
{{ to.selectAllOption }}| get value() { return this.formControl.value || []; } | ||
| get state() { | ||
| if (this.value.length > 0) { | ||
| return this.value.length !== this.formFieldControl.options.length |
There was a problem hiding this comment.
👍 for formFieldControl.options
| ); | ||
| } | ||
|
|
||
| getSelectAllLabel() { |
| description: 'Description', | ||
| required: true, | ||
| multiple: true, | ||
| selectAllOption: true, |
There was a problem hiding this comment.
pass string instead:
selectAllOption: 'Select All',
|
Gonna fix them tomorrow 👍 (ehm..later today actually 😅, it's 00:53am here) |
juristr
force-pushed
the
feat/multi-select-selectall
branch
from
5dce775
to
c32e9d2
Compare
|
Alright, applied the necessary changes and added a test to verify the option label is properly set 👍 |
|
LGTM, I let you merge this PR! 🎉🎉 |
juristr
force-pushed
the
feat/multi-select-selectall
branch
from
c32e9d2
to
a4708ac
Compare
| toggleSelectAll() { | ||
| this.formControl.setValue( | ||
| this.value.length !== this.formFieldControl.options.length | ||
| ? this.formFieldControl.options.map(x => x.value) |
There was a problem hiding this comment.
This doesn't work with option groups.
I think that would work:
this.formFieldControl.options.map(
x => (x.group ? x.group.map(grp => grp.value) : x.value)
).flat()There was a problem hiding this comment.
@fontsie yep in fact it doesn't . Can u open a new issue. We should work on a PR to fix it
This PR implements the new feature described in #1516 .
selectAllOptionconfigurationselectAllOption. String will be used as label if provided