Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material): adds datepicker toggle positioning support #1560

Merged
merged 1 commit into from
Apr 26, 2019
Merged

feat(material): adds datepicker toggle positioning support #1560

merged 1 commit into from
Apr 26, 2019

Conversation

ryanjerskine
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Add support for datepickerTogglePosition which support prefix/suffix. By default, the icon is missing.

What is the current behavior? (You can also link to an open issue here)
The toggle currently only supports suffix.

What is the new behavior (if this is a feature change)?
Support for prefix/suffix/none.

@aitboudad aitboudad closed this Apr 26, 2019
@aitboudad aitboudad reopened this Apr 26, 2019
Copy link
Member

@aitboudad aitboudad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adjusted your PR a little bit 😄

@ryanjerskine
Copy link
Contributor Author

Looks much better than my solution. Thanks!

@aitboudad aitboudad merged commit 63698b3 into ngx-formly:master Apr 26, 2019
@aitboudad
Copy link
Member

Thank you @ryanjerskine, it should be available in V5.1.

use the watch, to get notified on released!
Selection_005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants