Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): emit statusChanges on updateValueAndValidity #2107

Merged
merged 1 commit into from
Feb 19, 2020
Merged

fix(core): emit statusChanges on updateValueAndValidity #2107

merged 1 commit into from
Feb 19, 2020

Conversation

aitboudad
Copy link
Member

fix #2106

@aitboudad aitboudad closed this Feb 19, 2020
@aitboudad aitboudad reopened this Feb 19, 2020
@aitboudad aitboudad merged commit 27ef27c into ngx-formly:v5 Feb 19, 2020
@aitboudad aitboudad deleted the 2106 branch February 19, 2020 16:21
aitboudad added a commit that referenced this pull request Feb 20, 2020
@aitboudad
fix(core): emit statusChanges on updateValueAndValidity (#2107)
7deac1a 
fix #2106
@kritisoft
Copy link

I think this issue still persists on async validators .
It is Working on the parent form, but when I use it in the child form, I need to manually update it.

@aitboudad
Copy link
Member Author

@kritisoft please fill a new issue with a reproduction example, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular Material - validation message not showing if required set dynamically
2 participants
@aitboudad @kritisoft