Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material): mat-slider thumbLabel support #2190

Merged
merged 1 commit into from Apr 20, 2020
Merged

feat(material): mat-slider thumbLabel support #2190

merged 1 commit into from Apr 20, 2020

Conversation

skrtheboss
Copy link
Contributor

@skrtheboss skrtheboss commented Apr 20, 2020

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds support for enabling thumLabel in material slider.

What is the current behavior? (You can also link to an open issue here)

Step, max, min are supported on sliders through the templateOptions properties.
However, specifying whether the thumLabel is enabled or not is not supported.

What is the new behavior (if this is a feature change)?
You can enable the thumLabel via the templateOptions.

Please check if the PR fulfills these requirements

Please provide a screenshot of this feature before and after your code changes, if applicable.

Other information:

@netlify
Copy link

netlify bot commented Apr 20, 2020

Deploy preview for formly-dev ready!

Built with commit e11726a

https://deploy-preview-2190--formly-dev.netlify.app

@aitboudad aitboudad changed the title feat(material): mat-slider thumbLabel support (#2188) feat(material): mat-slider thumbLabel support Apr 20, 2020
@aitboudad aitboudad merged commit d6a0e20 into ngx-formly:v5 Apr 20, 2020
@aitboudad
Copy link
Member

Thank you @skrtheboss!

@skrtheboss skrtheboss deleted the feat/2188-add-mat-slider-thumb-label-support branch April 21, 2020 11:39
@aitboudad
Copy link
Member

added in 5.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants