fix(core): fix OnPush FieldTypes not being change detected #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix OnPush FieldTypes not being change detected on expressionProperties changes
|
Deploy preview for formly-dev ready! Built with commit 701e2e6 |
|
Thanks for this. |
aitboudad
changed the title
|
Thank you @skrtheboss! |
aitboudad
pushed a commit
that referenced
this pull request
Apr 22, 2020
Fix OnPush FieldTypes not being change detected on expressionProperties changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix OnPush FieldTypes not being change detected on expressionProperties changes.
What is the current behavior? (You can also link to an open issue here)
If ChangeDetectionStrategy.OnPush is used in a custom FieldType, then the templateOptions which are generated via expressionProperties, do not result in a changeDetection check.
What is the new behavior (if this is a feature change)?
If a expression property changes, the FieldType is change detected properly.
Please check if the PR fulfills these requirements
npm run buildproduced a successful build. (Unit testing can be done by runningnpm test;)npm run lintto do this.npm run buildwill fail if there are files not linted.)