-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap 5 support #2846
Bootstrap 5 support #2846
Conversation
Deploy preview for formly-dev ready! Built with commit 94f3b30 |
✔️ Deploy Preview for formly-dev ready! 🔨 Explore the source changes: 87a8835 🔍 Inspect the deploy log: https://app.netlify.com/sites/formly-dev/deploys/611ecbd43a0e4e0007e73889 😎 Browse the preview: https://deploy-preview-2846--formly-dev.netlify.app/ |
I believe this is now ready for review. There is a failing test in |
👍, I think we need to mention the new change in our UPGRADE file |
@aitboudad Added the upgrade documentation (I left a blank space for core docs if needed) and updated the README ready for ng12. (This assumes v6 is targeting n11+12, and v7 is targeting ng12 + bootstrap5 which is probably incorrect so let me know and I'll push the fix) |
I think this should be done in formly v6 not v7, because v6 is currently just a pre-release. |
Do you not want bootstrap 4 users to be able to use ng12 though? Can v5 already use Angular 12? |
this feature will be added in
it should work I think |
I will update the PR accordingly |
I believe this is now ready. |
Has this PR been merged into a pre-release deploy for |
it'll be included in our next alpha |
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Thank you @internalsystemerror! |
Hi, thanks for your great work! We need a new release of version6 to support Bootstrap 5. Thanks in advance! |
I'll make sure to make a new release this week which include this feature |
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Bootstrap 5 support is released in https://github.com/ngx-formly/ngx-formly/releases/tag/v6.0.0-next.4, we'll switch into beta release within 1/2 weeks. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Update bootstrap to v5
What is the current behavior? (You can also link to an open issue here)
Bootstrap v4 is used
What is the new behavior (if this is a feature change)?
Bootstrap v5 is used
Please check if the PR fulfills these requirements
npm run build
produced a successful build. (Unit testing can be done by runningnpm test
;)npm run lint
to do this.npm run build
will fail if there are files not linted.)Please provide a screenshot of this feature before and after your code changes, if applicable.
N/A (visual changes should be none if possible)
Other information:
I had a go at implementing floating labels, however this would require the form control to be a direct sibling to the label, which I'm not sure is possible currently. Alternatively we could include the entire floating label css but rewritten (the first option would be ideal however).
Closes #2832.