Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 5 support #2846

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Bootstrap 5 support #2846

merged 1 commit into from
Aug 19, 2021

Conversation

internalsystemerror
Copy link
Contributor

@internalsystemerror internalsystemerror commented May 18, 2021

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Update bootstrap to v5

What is the current behavior? (You can also link to an open issue here)
Bootstrap v4 is used

What is the new behavior (if this is a feature change)?
Bootstrap v5 is used

Please check if the PR fulfills these requirements

Please provide a screenshot of this feature before and after your code changes, if applicable.
N/A (visual changes should be none if possible)

Other information:
I had a go at implementing floating labels, however this would require the form control to be a direct sibling to the label, which I'm not sure is possible currently. Alternatively we could include the entire floating label css but rewritten (the first option would be ideal however).

Closes #2832.

@netlify
Copy link

netlify bot commented May 18, 2021

Deploy preview for formly-dev ready!

Built with commit 94f3b30

https://deploy-preview-2846--formly-dev.netlify.app

@netlify
Copy link

netlify bot commented May 18, 2021

✔️ Deploy Preview for formly-dev ready!

🔨 Explore the source changes: 87a8835

🔍 Inspect the deploy log: https://app.netlify.com/sites/formly-dev/deploys/611ecbd43a0e4e0007e73889

😎 Browse the preview: https://deploy-preview-2846--formly-dev.netlify.app/

@internalsystemerror internalsystemerror changed the title WIP: Bootstrap 5 support Bootstrap 5 support May 19, 2021
@internalsystemerror
Copy link
Contributor Author

I believe this is now ready for review. There is a failing test in core but I believe this to have already been failing before the changes involved in this PR, since this is based on the main branch.

@aitboudad
Copy link
Member

👍, I think we need to mention the new change in our UPGRADE file

@internalsystemerror
Copy link
Contributor Author

internalsystemerror commented May 21, 2021

@aitboudad Added the upgrade documentation (I left a blank space for core docs if needed) and updated the README ready for ng12.

(This assumes v6 is targeting n11+12, and v7 is targeting ng12 + bootstrap5 which is probably incorrect so let me know and I'll push the fix)

@manuelmeister
Copy link
Contributor

I think this should be done in formly v6 not v7, because v6 is currently just a pre-release.

@internalsystemerror
Copy link
Contributor Author

Do you not want bootstrap 4 users to be able to use ng12 though? Can v5 already use Angular 12?

@aitboudad
Copy link
Member

this feature will be added in V6 not V7.

Can v5 already use Angular 12?

it should work I think

@internalsystemerror
Copy link
Contributor Author

I will update the PR accordingly

@internalsystemerror
Copy link
Contributor Author

I believe this is now ready.

@Allcharles
Copy link

this feature will be added in V6 not V7.

Can v5 already use Angular 12?

it should work I think

Has this PR been merged into a pre-release deploy for V6 yet? Bootstrap 5 has been out for a while now and I would love to begin the process of migrating my website.

@aitboudad
Copy link
Member

Has this PR been merged into a pre-release deploy for V6 yet?

it'll be included in our next alpha

Signed-off-by: Gary Lockett <gary@creativecow.uk>
@aitboudad aitboudad merged commit b622108 into ngx-formly:main Aug 19, 2021
@aitboudad
Copy link
Member

Thank you @internalsystemerror!

@internalsystemerror internalsystemerror deleted the feature/bootstrap5 branch August 20, 2021 10:03
@Wanchai
Copy link

Wanchai commented Nov 17, 2021

Hi, thanks for your great work!

We need a new release of version6 to support Bootstrap 5.

Thanks in advance!

@aitboudad
Copy link
Member

I'll make sure to make a new release this week which include this feature

aitboudad pushed a commit that referenced this pull request Dec 1, 2021
Signed-off-by: Gary Lockett <gary@creativecow.uk>
@aitboudad
Copy link
Member

Bootstrap 5 support is released in https://github.com/ngx-formly/ngx-formly/releases/tag/v6.0.0-next.4, we'll switch into beta release within 1/2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap 5 Plans
5 participants