feat(core): improve Formly config structure #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitboudad
force-pushed
the
formly_config
branch
from
9a29f0c
to
e678517
Compare
✅ Deploy Preview for formly-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aitboudad
force-pushed
the
formly_config
branch
from
e678517
to
78d5197
Compare
✅ Deploy Preview for formly-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for formly-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -56,6 +57,18 @@ export class CoreExtension implements FormlyExtension { | |||
| this.getFieldComponentInstance(field).postPopulate?.(field); | |||
| } | |||
|
|
|||
| private initFieldProps(field: FormlyFieldConfigCache) { | |||
| if (!field.props) { | |||
There was a problem hiding this comment.
Suggested change
| if (!field.props) { | |
| field.props ??= field.templateOptions |
| @@ -34,7 +34,10 @@ export interface FormlyFieldConfig { | |||
| /** | |||
| * This is reserved for the templates. Any template-specific options go in here. Look at your specific template implementation to know the options required for this. | |||
| */ | |||
| templateOptions?: FormlyTemplateOptions; | |||
| props?: FormlyFieldProps; | |||
There was a problem hiding this comment.
export interface FormlyFieldConfig<Props extends FormlyFieldProps> {
…
props?: Props;This could be a generic. Then you could make union types of the fields and get better type autocompletion.
E.g:
export interface TextareaFieldConfig extends FormFieldConfig<TextareaProps> {
type: "textarea";
}
export interface TextareaProps extends FormlyFieldProps {
row: number;
cols: number;
}
export type FieldConfigTypes = TextareaFieldConfig | TelephoneFieldConfig | …;And then I would urgently remove additionalProps as this makes accurate typing much more difficult.
For the transition I would allow these additionalProps only at templateOptions and not at props.
Comment on lines
+40
to
+41
| get props() { | ||
| return (this.field.props || {}) as NonNullable<F['props']>; |
There was a problem hiding this comment.
Suggested change
| get props() { | |
| return (this.field.props || {}) as NonNullable<F['props']>; | |
| get props(): NonNullable<F['props']> { | |
| this.field.props ??= {}; | |
| return this.field.props; |
Is this not needed?
|
@manuelmeister would you like provide a PR for these changes? |
|
I'm currently quite busy, so I'm don't know when I have time to implement this. |
|
Ok, will do it then! |
aitboudad
added a commit
to aitboudad/ngx-formly
that referenced
this pull request
May 14, 2022
aitboudad
added a commit
to aitboudad/ngx-formly
that referenced
this pull request
May 14, 2022
aitboudad
added a commit
to aitboudad/ngx-formly
that referenced
this pull request
May 14, 2022
aitboudad
added a commit
that referenced
this pull request
May 14, 2022
aitboudad
added a commit
to aitboudad/ngx-formly
that referenced
this pull request
May 21, 2022
aitboudad
added a commit
to aitboudad/ngx-formly
that referenced
this pull request
May 21, 2022
aitboudad
added a commit
to aitboudad/ngx-formly
that referenced
this pull request
May 21, 2022
aitboudad
added a commit
to aitboudad/ngx-formly
that referenced
this pull request
May 21, 2022
aitboudad
added a commit
that referenced
this pull request
May 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2853