-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): remove additionalProps from FormlyFieldProps interface #3295
Conversation
❌ Deploy Preview for formly-dev failed.
|
❌ Deploy Preview for formly-dev failed.
|
✅ Deploy Preview for formly-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -5,7 +5,7 @@ import { FieldWrapper } from '../templates/field.wrapper'; | |||
import { ValidationMessageOption } from '../models'; | |||
import { Type } from '@angular/core'; | |||
|
|||
export interface FormlyFieldConfig { | |||
export interface FormlyFieldConfig<Props = FormlyFieldProps & { [additionalProperties: string]: any }> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export interface FormlyFieldConfig<Props = FormlyFieldProps & { [additionalProperties: string]: any }> { | |
export interface FormlyFieldConfig<Props = FormlyFieldProps> { |
Why does this again have the additionalProperties? I thought this should only be allowed on templateOptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FormlyFieldConfig
should allow additionalProperties, to make it strict simply use FormlyFieldConfig<FormlyFieldProps>
. You may check #3303 to have a clear idea for strict
mode.
fix #3242