Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kendo): add primitive option in props #3620

Merged
merged 3 commits into from Aug 28, 2023

Conversation

luizfbicalho
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
kendo template has fixed value in primitive, if you need to pass an object on the value it makes an error

What is the current behavior? (You can also link to an open issue here)
#3529

What is the new behavior (if this is a feature change)?
there will be a primitive prop value on kendo select props

Please check if the PR fulfills these requirements

Please provide a screenshot of this feature before and after your code changes, if applicable.

Other information:

@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for formly-dev ready!

Name Link
🔨 Latest commit 61c17b3
🔍 Latest deploy log https://app.netlify.com/sites/formly-dev/deploys/6407c62fe63d0a00087ac23c
😎 Deploy Preview https://deploy-preview-3620--formly-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@luizfbicalho
Copy link
Contributor Author

@aitboudad what's the impact of this change?

@aitboudad
Copy link
Member

@luizfbicalho I'll merge it soon, just need some time to test it on my side.

@luizfbicalho
Copy link
Contributor Author

Hey @aitboudad Is this dead?

@aitboudad aitboudad merged commit a0b4d7d into ngx-formly:main Aug 28, 2023
1 check passed
@aitboudad
Copy link
Member

Thank you @luizfbicalho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants