Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bootstrap): added aria tags for input validation (#3737) #3740

Merged
merged 1 commit into from Sep 16, 2023

Conversation

rpw1
Copy link
Contributor

@rpw1 rpw1 commented Jul 13, 2023

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a feature change to allow for screen reader to mention that an input is invalid and to read the validation error message that is paired with the form control.

What is the current behavior? (You can also link to an open issue here)
The current behavior is to not use aria-invalid or aria-descibedby. Here is the issue I created for this problem

What is the new behavior (if this is a feature change)?
The new change will only affect screen readers in bootstrap. It will now read that an input is invalid once shown error is called, and it will also read the error message that is paired with the form control.

Please check if the PR fulfills these requirements

Please provide a screenshot of this feature before and after your code changes, if applicable.

Other information:

@rpw1
Copy link
Contributor Author

rpw1 commented Jul 13, 2023

I would very much appreciate helping me complete this pull request. This is helping to make Formly ADA compliant

@rpw1
Copy link
Contributor Author

rpw1 commented Aug 8, 2023

Hi it has been some time since I have submitted this pull request. Is there anything I can do to speed up the process? Is this change something that you would prefer not adding to your product?

Thanks

@aitboudad
Copy link
Member

Hi, Thanks for the PR, I'll be able to check and merge the current work probably within max 2/3 weeks.
please note If you need that feature in your project I'd suggest to override form-field wrapper.

@rpw1
Copy link
Contributor Author

rpw1 commented Sep 6, 2023

@aitboudad Do you know when the work can be merged and the next release will occur? It is getting to the point to where I might need to start overriding the form-feild wrapper to achive this.

Thanks

@aitboudad
Copy link
Member

@rpw1 still not be able to check it 🙏, at the moment I'd suggest overriding form-feild.

@aitboudad aitboudad merged commit c4f7074 into ngx-formly:main Sep 16, 2023
1 check passed
@aitboudad
Copy link
Member

Thank you @rpw1!

@rpw1
Copy link
Contributor Author

rpw1 commented Sep 18, 2023

Thanks for taking the time to review and merge my changes. I very much appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants