feat(bootstrap): added aria tags for input validation (#3737) #3740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a feature change to allow for screen reader to mention that an input is invalid and to read the validation error message that is paired with the form control.
What is the current behavior? (You can also link to an open issue here)
The current behavior is to not use aria-invalid or aria-descibedby. Here is the issue I created for this problem
What is the new behavior (if this is a feature change)?
The new change will only affect screen readers in bootstrap. It will now read that an input is invalid once shown error is called, and it will also read the error message that is paired with the form control.
Please check if the PR fulfills these requirements
npm run build
produced a successful build. (Unit testing can be done by runningnpm test
;)npm run lint
to do this.npm run build
will fail if there are files not linted.)Please provide a screenshot of this feature before and after your code changes, if applicable.
Other information: