fix(bootstrap): update multicheckbox aria attr in input tag #3793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Commit 1: This bug fix is to have the aria-describedby and aria-isinvalid to be in the input tag and not the div tag for the multicheckbox form field.
Commit2: Added role tag to formly-validation-message. This lets a screen reader know to read out the message as it appears, instead of the second time visited.
Commit3: Added unit test for multicheckbox form field type. Added is-invalid class on showError.
What is the current behavior? (You can also link to an open issue here)
Input validation errors are not being read by screen reader when presented.
Please check if the PR fulfills these requirements
npm run build
produced a successful build. (Unit testing can be done by runningnpm test
;)npm run lint
to do this.npm run build
will fail if there are files not linted.)