Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootstrap): update multicheckbox aria attr in input tag #3793

Merged

Conversation

rpw1
Copy link
Contributor

@rpw1 rpw1 commented Oct 10, 2023

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Commit 1: This bug fix is to have the aria-describedby and aria-isinvalid to be in the input tag and not the div tag for the multicheckbox form field.

Commit2: Added role tag to formly-validation-message. This lets a screen reader know to read out the message as it appears, instead of the second time visited.

Commit3: Added unit test for multicheckbox form field type. Added is-invalid class on showError.

What is the current behavior? (You can also link to an open issue here)
Input validation errors are not being read by screen reader when presented.

Please check if the PR fulfills these requirements

@aitboudad aitboudad merged commit c78462a into ngx-formly:main Oct 28, 2023
1 check passed
@aitboudad
Copy link
Member

Thank you @rpw1!

@aitboudad
Copy link
Member

This PR has been released as part of v6.2.2 release.

@rpw1
Copy link
Contributor Author

rpw1 commented Oct 30, 2023

Thank you for including my PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants