Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Angular 10 #1225

Closed
PapaNappa opened this issue Jun 25, 2020 · 1 comment
Closed

Add compatibility with Angular 10 #1225

PapaNappa opened this issue Jun 25, 2020 · 1 comment

Comments

@PapaNappa
Copy link

Current behavior

When updating an Angular 9 application to Angular 10 (ng update @angular/core @angular/cli), the following error message appears:

                  Package "@ngx-translate/core" has an incompatible peer dependency to "tslib" (requires "^1.10.0", would install "2.0.0").
× Migration failed: Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.

Expected behavior

I should first update ngx-translate to a supported version and then updgrade should go smoothly.

How do you think that we should fix this?

Update ngx-translate/core itself to Angular 10 so a compatible package.json is generated and a compatible tslib version is used.
It also seems that tslib moved from being a 'peerDependency' to being a 'dependency' with Angular 10.

Minimal reproduction of the problem with instructions

I can create a short script later on if requested.

Environment


ngx-translate version: 12.1.2
Angular version: 10.0.0

@ocombe ocombe closed this as completed in efcb4f4 Jun 26, 2020
@ocombe
Copy link
Collaborator

ocombe commented Jun 26, 2020

Thanks for the report, v13 is out for Angular v10!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants