You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I allow myself to open a change request because one of your functions is not clear in its signature.
In the file "translate.service.ts", you expose a "use" method which has as signature an "Observable ". When I see a function signed with an "Observable ", I automatically tell myself that this function is asynchronous. I expect to have full control over when and how the code will be executed.
However, synchronous code is executed in this method. I find it very disturbing to call a function signed "Observable " without a subscribe as you advise in your documentation.
Example: this._translateService.use ()
Waiting for an answer, see you soon!
The text was updated successfully, but these errors were encountered:
Hello
I allow myself to open a change request because one of your functions is not clear in its signature.
In the file "translate.service.ts", you expose a "use" method which has as signature an "Observable ". When I see a function signed with an "Observable ", I automatically tell myself that this function is asynchronous. I expect to have full control over when and how the code will be executed.
However, synchronous code is executed in this method. I find it very disturbing to call a function signed "Observable " without a subscribe as you advise in your documentation.
Example: this._translateService.use ()
Waiting for an answer, see you soon!
The text was updated successfully, but these errors were encountered: