Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect signature of use () function #1227

Open
jboileau173 opened this issue Jul 1, 2020 · 1 comment
Open

Incorrect signature of use () function #1227

jboileau173 opened this issue Jul 1, 2020 · 1 comment

Comments

@jboileau173
Copy link

Hello

I allow myself to open a change request because one of your functions is not clear in its signature.

In the file "translate.service.ts", you expose a "use" method which has as signature an "Observable ". When I see a function signed with an "Observable ", I automatically tell myself that this function is asynchronous. I expect to have full control over when and how the code will be executed.

However, synchronous code is executed in this method. I find it very disturbing to call a function signed "Observable " without a subscribe as you advise in your documentation.

Example: this._translateService.use ()

Waiting for an answer, see you soon!

@rattkin
Copy link

rattkin commented Sep 3, 2020

I subscribed just for fun. The result is the language json contents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants