Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump angular 17 #1455

Closed
damingerdai opened this issue Nov 10, 2023 · 3 comments
Closed

bump angular 17 #1455

damingerdai opened this issue Nov 10, 2023 · 3 comments

Comments

@damingerdai
Copy link

No description provided.

@damingerdai damingerdai mentioned this issue Nov 10, 2023
Closed
@ocombe
Copy link
Collaborator

ocombe commented Nov 10, 2023

What about it ? Current implementation is already compatible with angular v17 as far as I know

@ocombe ocombe closed this as completed Nov 10, 2023
@damingerdai
Copy link
Author

damingerdai commented Nov 10, 2023 •
edited
Loading

My meaning is not that to support angular 17. I think we need build the repo with angular 17

@kgish
Copy link

kgish commented Dec 1, 2023

doesn't work on angular 17 (no more ngModule) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kgish @ocombe @damingerdai