Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Support For Api 8 #288

Closed
wants to merge 5 commits into from
Closed

Support For Api 8 #288

wants to merge 5 commits into from

Conversation

ertanden
Copy link

@ertanden ertanden commented Nov 2, 2014

I know you rejected the previous pull request, but check this out. I fixed most of the issues. Very minor problems remained with drag&drop. Try the example app on an emulator and see for yourself. 10% of potential customers is a lot for applications with million or more installs. It would be good to support API >= 8.

  • Add support for API >= 8 for the example app with AppCompat library.
  • Updated Drag&Drop code to use NineOldAndroids. Fixed most of the problems for API < 14. The only problem left is that the mobileView does not become invisible...
  • Fixed a problem which prevented running the app on an Emulator without Google Play Store.
  • Fixed issue #254 (looks like recycling was still a problem on >= 14 but much less visible than < 14)

@WonderCsabo
Copy link
Contributor

For bigger features i suggest opening an issue first, so PRs more likely gets accepted after planning.

This works only when SimpleSwipeUndo is enabled too. When it's not enabled the mobileView remains is visible.
@ertanden
Copy link
Author

ertanden commented Nov 2, 2014

Known glitches after latest fixes (I can live with them for now):

  1. Swap animations when dragging are disabled for API < 14. They cause strange behaviour.
  2. When SwipUndo is not enabled, the mobileView is still visible when dragging. (When it's enabled, it works good)

@nhaarman
Copy link
Owner

nhaarman commented Nov 4, 2014

The swap animations were indeed causing trouble <14. Disabling them seems a good compromise.
I'll look through your code.

@nhaarman
Copy link
Owner

nhaarman commented Nov 4, 2014

See 7b788cd.
Thanks!

@nhaarman nhaarman closed this Nov 4, 2014
@mazurio
Copy link

mazurio commented Dec 9, 2014

Hello, is there any solution regarding support for API 8?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants