Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntercomSettings persist on window object after shutdown #39

Closed
michaelReyder opened this issue Oct 30, 2017 · 1 comment
Closed

IntercomSettings persist on window object after shutdown #39

michaelReyder opened this issue Oct 30, 2017 · 1 comment

Comments

@michaelReyder
Copy link

After attempting to use this component, I noticed that there was some strange behaviour happening in my Intercom dashboard. Without going too deep into the details, I noticed that even after Intercom is shut down, the IntercomSettings property on the window object remains there.

In your code, within the componentWillUnmount lifecycle hook you delete the window.Intercom property after running window.Intercom('shutdown'), but you never delete the window.IntercomSettings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants