Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Command Palette "Set max_tokens" using "enter" auto-submits Popup #47

Closed
limex opened this issue Dec 6, 2022 · 4 comments
Closed

Comments

@limex
Copy link

limex commented Dec 6, 2022

Obsidian 1.03 on MacOS

Steps:

  • Open Command Palette with Command+P
  • Type "Text" to highlight the Command "Text Generator: Set max_tokens"
  • Press "Enter" Button

Expected:

  • Popup Dialog shows to edit the max_tokens

Observed:

  • Popup Dialog flashes for some milliseconds ;)
  • (probably) saves the existing setting
  • shows a toast in the upper right corner

Screen Recording 2022-12-06 at 18 27 25 (1)

Remark:
Option/Alt+1 opens the Popup Dialog without Problems

Thanks for the great plugin &
BR Günther

@nhaouari
Copy link
Owner

nhaouari commented Dec 6, 2022

Hi,

The plugin has been updated to version 0.1.13 and should be working now. If you have any further issues, please let me know.

Thank you,

@limex
Copy link
Author

limex commented Dec 6, 2022

Hi, sorry, still the same issue.
Update, restarted, Forced Reload, Checked Console: is empty

@nhaouari
Copy link
Owner

nhaouari commented Dec 6, 2022

The plugin has been updated to version 0.1.14, and I have added more delay between opening the model and listening to ''enter key'' (from 100ms, which works fine for me, to 500ms).

@limex
Copy link
Author

limex commented Dec 7, 2022

Works now. Thanks.

@limex limex closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants