Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which is the best postgres seneca module to use? #16

Closed
faceleg opened this issue Aug 1, 2015 · 3 comments
Closed

Which is the best postgres seneca module to use? #16

faceleg opened this issue Aug 1, 2015 · 3 comments

Comments

@faceleg
Copy link

faceleg commented Aug 1, 2015

I see this is a fork of @marianr's work - which is most stable?

Would it be possible to have them merged into the ONE TRUE SENECA POSTGRESQL STORE?

@brycereynolds
Copy link

+1

I'd love to contribute and considering the additions I see in this branch I'm planning on forking here. @nherment what is the timeline for a PR of this branch or is that not the intention here?

@nherment
Copy link
Owner

As far as I know this one is the latest and more stable.
There is no current plan to merge the two branches the main reasons being:

  • this one has been renamed
  • we now have a commitment to support this current branch

I agree it's not an ideal solution but the fact that:

  • the commits clearly show which branch has the most activity
  • I'm unsure about the current usage of @marianr's npm package dependents or branch dependents
  • because of support commitments we're probably unwilling to rename this branch back to marianr's original one
  • I think in any case we should not delete marianr's branch, just for the sake of historical reasons :)
  • And probably most importantly I currently don't have the bandwidth to look into it :/

I'll see if I can add a note to marianr's branch readme file to redirect here, with his approval.

@brycereynolds PRs are absolutely welcome on this branch.

@faceleg
Copy link
Author

faceleg commented Aug 12, 2015

Thanks to the thorough answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants