fix: underline(_) is not allowed inside words(fix #409)

nhn · Mar 14, 2019 · 00b75fa · 00b75fa
1 parent 12ab35f
commit 00b75fa
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/js/markdownCommands/italic.js b/src/js/markdownCommands/italic.js
@@ -87,7 +87,7 @@ const Italic = CommandManager.command('markdown', /** @lends Italic */{
    * @returns {string} - italic text
    */
   append(text) {
-    return `_${text}_`;
+    return `*${text}*`;
   },
 
   /**

diff --git a/test/e2e/markdown/toolbar/italic.spec.js b/test/e2e/markdown/toolbar/italic.spec.js
@@ -10,7 +10,7 @@ test('click italic button then type text', async t => {
     .pressKey('e')
     .pressKey('s')
     .pressKey('t')
-    .expect(editor.markdown.lines.nth(0).textContent).eql('_test_')
+    .expect(editor.markdown.lines.nth(0).textContent).eql('*test*')
     .expect(editor.markdown.preview.innerHTML).contains('<em>');
 });
 
@@ -24,6 +24,6 @@ test('type text, select the text then click italic button', async t => {
     .pressKey('home')
     .pressKey('shift+end')
     .click(editor.toolbar.italic)
-    .expect(editor.markdown.lines.nth(0).textContent).eql('_test_')
+    .expect(editor.markdown.lines.nth(0).textContent).eql('*test*')
     .expect(editor.markdown.preview.innerHTML).contains('<em>');
 });
diff --git a/test/unit/markdownCommands/italic.spec.js b/test/unit/markdownCommands/italic.spec.js
@@ -36,15 +36,15 @@ describe('Italic', () => {
 
       Italic.exec(mde);
 
-      expect(cm.getValue()).toEqual(['mytext1', '', 'myt__ext2', 'mytext3'].join('\n'));
+      expect(cm.getValue()).toEqual(['mytext1', '', 'myt**ext2', 'mytext3'].join('\n'));
     });
 
     it('in a blank line', () => {
       doc.setCursor(1, 3);
 
       Italic.exec(mde);
 
-      expect(cm.getValue()).toEqual(['mytext1', '__', 'mytext2', 'mytext3'].join('\n'));
+      expect(cm.getValue()).toEqual(['mytext1', '**', 'mytext2', 'mytext3'].join('\n'));
     });
 
     it('around selected text', () => {
@@ -58,7 +58,7 @@ describe('Italic', () => {
 
       Italic.exec(mde);
 
-      expect(cm.getValue()).toEqual(['_mytext1_', '', 'mytext2', 'mytext3'].join('\n'));
+      expect(cm.getValue()).toEqual(['*mytext1*', '', 'mytext2', 'mytext3'].join('\n'));
     });
 
     it('should remove italic syntax in the middle of the given range', () => {
@@ -74,7 +74,7 @@ describe('Italic', () => {
 
       Italic.exec(mde);
 
-      expect(cm.getValue()).toEqual('_my text 1_');
+      expect(cm.getValue()).toEqual('*my text 1*');
     });
   });
 });