Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in changing corner properties #49

Closed
OculusMode opened this issue Jul 28, 2018 · 4 comments
Closed

Issue in changing corner properties #49

OculusMode opened this issue Jul 28, 2018 · 4 comments
Labels
Enhancement Enhance performance or improve usability of original features.

Comments

@OculusMode
Copy link

Version

Any

Development Environment

Any

Current Behavior

I'm trying to change corner details in your js file.
However all the other changes are working except cornerSize .
How can i fix it?

I found that you are using very older version of fabric.
Will upgrading fabric will work in this situation.?

And as a feature request, can you add a method to change corner properties in next update?

Looking forward for response.

tui-image-editor.js line: 3865

fObjectOptions: {
	        SELECTION_STYLE: {
	            borderColor: 'red',
	            cornerColor: 'green',
	            cornerSize: 10,
	            originX: 'center',
	            originY: 'center',
	            transparentCorners: false
	        }
	    },
@jinwoo-kim-nhn
Copy link
Contributor

@OculusMode

Fabric version up will not have much effect right now.
I've confirmed that the selectionStyle option exists but does not work now.
I will fix this and include it in the next distribution.

@OculusMode
Copy link
Author

@jinwoo-kim-nhn thanks for reply, i just found out that while creating instance, i specified cornerSize which overridden size specified in tui-image-editor.js

imageEditor = new ImageEditor(document.querySelector("#myImageEditor"), {
        cssMaxWidth: 700,
        cssMaxHeight: 500,
        selectionStyle: {
          cornerSize: size,
          rotatingPointOffset: 70
        }
      });

Still problem is, if image is larger, then the corner seems very small.
i can figure out dynamically size of corner by calculating imageHeight and width you give after loading image but can't figure out how to set it(after instance is already created.)

@jinwoo-kim-nhn
Copy link
Contributor

@OculusMode
I already have it in mind.
We are considering a fundamental solution.
The dynamically changing options also look good.

@jinwoo-kim-nhn jinwoo-kim-nhn added the Enhancement Enhance performance or improve usability of original features. label Dec 27, 2018
@lja1018 lja1018 closed this as completed Nov 13, 2020
@awwaiid
Copy link

awwaiid commented Aug 28, 2021

What happened with this? It seems like the corners are still scaling with the image size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance performance or improve usability of original features.
Projects
None yet
Development

No branches or pull requests

4 participants