Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating the editor instance makes image disappear. #59

Closed
humblecoder opened this issue Sep 12, 2018 · 6 comments
Closed

Rotating the editor instance makes image disappear. #59

humblecoder opened this issue Sep 12, 2018 · 6 comments

Comments

@humblecoder
Copy link

Version

3.2.0

Development Environment

MacOS 10.12.6
Chrome Version 68.0.3440.106 (Official Build) (64-bit)

Current Behavior

Using editorInstance.rotate(degrees) causes entire image/canvas to disappear. The initial image is retrieved from URL on load. I can save and reload images just fine. I can also add text, draw, etc without issue. However using .rotate() immediately makes the image disappear. The number of degrees is irrelevant and reversing the rotation doesn't make it reappear.

@humblecoder
Copy link
Author

I'm not sure if this is the "answer" but I've found that manually calling resizeCanvas(width,height) makes it reappear. Hopefully someone has a better answer. 😕

@jinwoo-kim-nhn
Copy link
Contributor

@humblecoder

I want to help, but I can not reproduce it, so it is hard to help. But the expected part is that images with too large a resolution may be slow or not working well.

@humblecoder
Copy link
Author

@jinwoo-kim-nhn any way to output relevant errors? As it stands, there's no feedback. 😢

@jinwoo-kim-nhn
Copy link
Contributor

@humblecoder
I'm sorry. The issue related to the rotate function is a recently discovered problem that I had not anticipated recently.
Perhaps it is related to browser performance, so it is hard to solve.
I will try to improve on this problem.

@humblecoder
Copy link
Author

@jinwoo-kim-nhn understood. FYI, I've tested it in the following browsers:

Chrome Version 69.0.3497.100 (Official Build) (64-bit)
Safari Version 12.0 (12606.2.11)
Firefox 62.0.3 (64-bit)
Opera Version:56.0.3051.36

@humblecoder
Copy link
Author

No longer seems to be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants