Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DST timezone bug #290

Closed
wants to merge 4 commits into from
Closed

fix: DST timezone bug #290

wants to merge 4 commits into from

Conversation

dongsik-yoo
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

#257
#258
#283


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@dongsik-yoo dongsik-yoo self-assigned this Mar 5, 2019
Copy link
Contributor

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[3/6]이견없습니다. 고생많으셨어요 👍

@cemrekahveci
Copy link

Hi! I was really happy to see that there was a fix, but it didn't work when I tried it. Now I see that the checks have failed. Is there any progress on this issue?

@dongsik-yoo
Copy link
Contributor Author

@cemrekahveci I've tried to fix this now. It's in progress. Can you provide what you are using DST information?

@cemrekahveci
Copy link

@cemrekahveci I've tried to fix this now. It's in progress. Can you provide what you are using DST information?

Do you mean what my timezone is currently? It's Europe/Amsterdam.

@dongsik-yoo
Copy link
Contributor Author

@cemrekahveci Yes I do. Thank you very much.

@hkarabakla
Copy link

Hello,
I'm also looking forward this fix, is there any progress ?

@antoarva
Copy link

antoarva commented Apr 3, 2019

Hello,
same problem here.

@dongsik-yoo
Copy link
Contributor Author

I'm in progress now! I'll be back with good news!

@dongsik-yoo
Copy link
Contributor Author

@cemrekahveci @hkarabakla @antoarva
Please confirm this fix version.

@antoarva
Copy link

@dongsik-yoo I replaced the new files from dist location and still when I create a slot in November it is shown 1 hour later than it really is

@dongsik-yoo
Copy link
Contributor Author

@antoarva Please give me some information.
What is your timezone name? Is the calendar type daily or weekly or monthly?
And let me know the date and year of November.

I fixed many issue about DST, but I can't fix an issue about 1 hour later thing yet on the day of time change. I think it will take longer time to fix.

@antoarva
Copy link

antoarva commented Apr 15, 2019

@dongsik-yoo My timezone is Europe/Amsterdam. In both weekly and daily view when I create a new schedule at 1 am the slot appeared on 2 am and this is happening from the first week of November 2019 until the last week of March 2020. Obviously does not take into account the summer time during that period.

@dongsik-yoo
Copy link
Contributor Author

I close this PR which solves #257 and #283.
#258 still remains unresolved. I'll be on another PR.

@adhrinae adhrinae deleted the fix/dst branch April 13, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants