New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DST timezone bug #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[3/6]이견없습니다. 고생많으셨어요 👍
Hi! I was really happy to see that there was a fix, but it didn't work when I tried it. Now I see that the checks have failed. Is there any progress on this issue? |
@cemrekahveci I've tried to fix this now. It's in progress. Can you provide what you are using DST information? |
Do you mean what my timezone is currently? It's Europe/Amsterdam. |
@cemrekahveci Yes I do. Thank you very much. |
Hello, |
Hello, |
I'm in progress now! I'll be back with good news! |
@cemrekahveci @hkarabakla @antoarva |
@dongsik-yoo I replaced the new files from dist location and still when I create a slot in November it is shown 1 hour later than it really is |
@antoarva Please give me some information. I fixed many issue about DST, but I can't fix an issue about 1 hour later thing yet on the day of time change. I think it will take longer time to fix. |
@dongsik-yoo My timezone is Europe/Amsterdam. In both weekly and daily view when I create a new schedule at 1 am the slot appeared on 2 am and this is happening from the first week of November 2019 until the last week of March 2020. Obviously does not take into account the summer time during that period. |
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
#257
#258
#283
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨