Substitute util.bind with Function.bind

[dilyanpalauzov]

As of https://caniuse.com/#feat=mdn-javascript_builtins_function_bind Function.bind is supported in IE +9, Edge +12 , Firefox +4, Chrome +7, Safari +5.1.

ScheduleCreationPopup._onClickListeners() uses Function.bind since April 2018, and TimeCreationGuide._onDrag uses it since Mai 2017, so the aforementioned browser versions are required that long.

• Replace util.bind(x,y) with x.bind(y)
• Update README.md with the minimal supported versions.

Please check if the PR fulfills these requirements

• It's submitted to right branch according to our branching model
• It's right issue type on title
• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes/features)
• Docs have been added/updated (for bug fixes/features)
• It does not introduce a breaking change or has description for the breaking change

[seonim-ryu]

Can one of the admins verify this patch?

[dongsik-yoo]

Supported browser versions should not be depending on compatibility of Function.prototype.bind

[dilyanpalauzov]

TimeCreationGuide._onDrag uses Function.bind since 2017 and therefore Safari 5.1+ is required that long. Just the documentation was not updated accordingly.

[jungeun-cho]

I think the browser support of the calendar application should not depend on any particular feature or method.

In the past, we used to support calendars even under IE9. So instead of using the bind function immediately, it was written using utility functions like a code snippet using call and apply.

The set of these utility functions is tui.code-snippet, but in calendar 1.x version, use tui.code-snippet version 1.x.

We are currently developing 2.0, and in 2.0 we will use tui.code-snippet 2.x and Function.prototype.bind. We will focus more on 2.0 development.

[dilyanpalauzov]

https://github.com/nhn/tui.calendar/blob/master/README.md#-browser-support says: “Safari → Yes. Internet Exporer → +9”. Does this mean,that tui calendar runs on Safari 3?

[dilyanpalauzov]

Besides, url('image/ic-unlock.png') was included twice in the css files: once in .{css-prefix}icon.{css-prefix}ic-public and once in .{css-prefix}section-private.{css-prefix}public .{css-prefix}ic-private. This resulted including the same uri:data: in dist/tui-calendar.css which bloats that file unnecessary.

[dilyanpalauzov]

handler/daygrid/creation.js contains domutils.getClass(target).trim(). String.trim() is supported as of https://caniuse.com/#feat=mdn-javascript_builtins_string_trim in Safari 5 but not in Safari 4. So Safari 5 is required since 2018 (since creation.js is that old).

[stale]

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

[dilyanpalauzov]

I would like to appeal once again to review which browsers version can be used to execute the current code, e.g. by checking what functions does the current codebase use.

[jungeun-cho]

@dilyanpalauzov
If you want to notify the browser version correctly,
Not only bind and trim
Browser compatibility should be checked in all code bases.
(For example, using the browser stack...)

The meaning yes was used as the latest. Normally, modern browsers are automatically updated. How many users use in safari3, safari4 ?

But there are still quite a few people using older IE browsers.

[dilyanpalauzov]

Nobody knows, what JavaScript functions can be used in the code, that are available in the browsers, and which not. This leads to bloated code.

E.g. currently the code uses Function.bind and according to https://caniuse.com/#feat=mdn-javascript_builtins_function_bind and https://caniuse.com/#search=indexof all browsers, which support Function.bind() also support Array.indexOf(). Yet the codebase uses instead tui-code-snippet.util.array.inArray() which is a (slower) polyfill for Array.indexOf(). This polyfill returns returns -1, when the parameter is not an array, but the polyfill is used also at places, where the parameter is clearly an array. At the same time Array.indexOf() is also used in the codebase, so that browsers running tui.calendar do understand it. Replacing util.inArray() with Array.indexOf() makes the code easier to understand and faster.

To know what can be used in CSS and JavaScritp, and what needs hacks, one has to describe very precisely the supported browsers. Firefox before 4 and Chrome before 7 are not supported.

[jungeun-cho]

It would make more sense to test all browser versions and write the correct version.

The meaning of yes is used with the meaning of latest and supported, and after testing for all browsers, it will not be changed unless it is the correct browser version.

[jungeun-cho]

@dilyanpalauzov
Can you re-request PR only to improve the bind?
can you revert only the README in this PR?

Can you register the browser compatibility part mentioned as a separate issue?
I'm going to discuss this with the team. :)

[dilyanpalauzov]

I have changed the herein proposed changes to only substitute util.bind() with Function.bind().

The discussion on documenting the minimal supported browsers in README.md is now at #666.

[jungeun-cho]

ok to test

[jungeun-cho]

[7/27] I reviewed. :)