Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace basicHTML with LinkeDOM #138

Closed
nhoizey opened this issue Feb 3, 2021 · 4 comments · Fixed by #172
Closed

Replace basicHTML with LinkeDOM #138

nhoizey opened this issue Feb 3, 2021 · 4 comments · Fixed by #172
Labels
package: images-responsiver ⚙️ priority: high 🟠 status: work in progress 🧰 type: dependencies 🔗 Pull requests that update a dependency file type: enhancement 🧗‍♂️

Comments

@nhoizey
Copy link
Owner

nhoizey commented Feb 3, 2021 •
edited
Loading

@nhoizey nhoizey mentioned this issue Jun 9, 2021
Closed
@nhoizey
Copy link
Owner Author

nhoizey commented Jun 9, 2021

Now critical priority because of #168

@nhoizey nhoizey mentioned this issue Jun 18, 2021
Closed
@nhoizey nhoizey pinned this issue Jun 18, 2021
@nhoizey
Copy link
Owner Author

nhoizey commented Jun 23, 2021 •
edited
Loading

Migration started in the linkedom branch.

Works really well overall, but facing an issue with dataset: WebReflection/linkedom#69

image

@nhoizey nhoizey mentioned this issue Jun 23, 2021
Closed
@nhoizey
Copy link
Owner Author

nhoizey commented Jun 24, 2021

Good progress made ! 🎉

images-responsiver-tests-with-linkedom

I have yet to find if this behavior with HTML entities is an issue:
WebReflection/linkedom#71

Help with real life examples welcome! 🙏

@nhoizey nhoizey changed the title Replace basicHTML with LinkeDOM? Replace basicHTML with LinkeDOM Jun 24, 2021
@nhoizey nhoizey mentioned this issue Jun 25, 2021
Merged
@nhoizey
Copy link
Owner Author

nhoizey commented Jun 25, 2021 •
edited
Loading

5 builds of my website with basicHTML:

  • Copied 918 files / Wrote 1671 files in 51.20 seconds (30.6ms each, v0.12.1)
  • Copied 918 files / Wrote 1671 files in 44.73 seconds (26.8ms each, v0.12.1)
  • Copied 918 files / Wrote 1671 files in 46.87 seconds (28.0ms each, v0.12.1)
  • Copied 918 files / Wrote 1671 files in 60.84 seconds (36.4ms each, v0.12.1)
  • Copied 918 files / Wrote 1671 files in 60.37 seconds (36.1ms each, v0.12.1)
  • Mean value: 52.802 seconds

5 builds with LinkeDOM:

  • Copied 918 files / Wrote 1671 files in 36.35 seconds (21.8ms each, v0.12.1)
  • Copied 918 files / Wrote 1671 files in 36.08 seconds (21.6ms each, v0.12.1)
  • Copied 918 files / Wrote 1671 files in 33.80 seconds (20.2ms each, v0.12.1)
  • Copied 918 files / Wrote 1671 files in 35.45 seconds (21.2ms each, v0.12.1)
  • Copied 918 files / Wrote 1671 files in 36.90 seconds (22.1ms each, v0.12.1)
  • Mean value: 36.316 seconds -> 31 % less!

This is a really great improvement! Thanks @WebReflection. 🙏

@nhoizey nhoizey unpinned this issue Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: images-responsiver ⚙️ priority: high 🟠 status: work in progress 🧰 type: dependencies 🔗 Pull requests that update a dependency file type: enhancement 🧗‍♂️
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace basicHTML with LinkeDOM nhoizey/images-responsiver
1 participant
@nhoizey