Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM #15

Closed
nhooyr opened this issue Sep 13, 2018 · 9 comments
Closed

WASM #15

nhooyr opened this issue Sep 13, 2018 · 9 comments
Labels
enhancement

Comments

@nhooyr
Copy link
Owner

nhooyr commented Sep 13, 2018

golang/go#27311

Can't really support the current API, browser API is different and much less expressive.
@nhooyr nhooyr added the p3 label Sep 13, 2018
@nhooyr nhooyr removed the p3 label Mar 14, 2019
@nhooyr
Copy link
Owner Author

nhooyr commented Mar 14, 2019

Probably a good idea to wait until the wasm support becomes more mature.

@nhooyr nhooyr added the complex label Mar 14, 2019
@nhooyr
Copy link
Owner Author

nhooyr commented Mar 30, 2019

Don't really think this is worth doing. Based on the current js API, I don't think Go has a shot at becoming a solid frontend language so I wouldn't want to spend time on this.

@nhooyr nhooyr closed this as completed Mar 30, 2019
@nhooyr
Copy link
Owner Author

nhooyr commented Mar 30, 2019

See gorilla/websocket#432

@nhooyr
Copy link
Owner Author

nhooyr commented Mar 30, 2019

Definitely open to revisiting this in the future when WASM support is more mature.

@nhooyr
Copy link
Owner Author

nhooyr commented Mar 30, 2019

Nvm, I think I this should be done. See https://www.reddit.com/r/golang/comments/b6y4h4/vugu_a_modern_ui_library_for_gowebassembly/

People do want to write frontend's in Go, I get it, the JS eco system isn't really good.

@nhooyr nhooyr reopened this Mar 30, 2019
@nhooyr nhooyr added this to the v1.0.0 milestone Mar 30, 2019
@nhooyr
Copy link
Owner Author

nhooyr commented Mar 30, 2019

Not 100% sure on this now as passing a custom net/http client will not work.

@nhooyr
Copy link
Owner Author

nhooyr commented Mar 30, 2019

I guess it'd just become a no-op. Seems janky for sure though but a lot of Go probably doesn't work in wasm so it should be fine.

@nhooyr nhooyr removed this from the v1.0.0 milestone Apr 12, 2019
@nhooyr
Copy link
Owner Author

nhooyr commented Apr 13, 2019

Another issue is that the browser has a websocket status code for when the tls handshake fails whereas we just return the handshake error and we can't return a *http.Response from Dial.

@nhooyr
Copy link
Owner Author

nhooyr commented May 17, 2019

I don't think this is worth it, lets revisit in the future.

@nhooyr nhooyr closed this as completed May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nhooyr