New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change protocol in docs and logs from http to ws #412

Merged

nhooyr merged 1 commit into nhooyr:dev from KunalSin9h:protocol

Oct 26, 2023

Contributor

KunalSin9h commented Oct 25, 2023

the websocket protocol require the protocol on the url to be ws not http, then we must log the url which is for websocket.

nhooyr approved these changes

View reviewed changes

Owner

nhooyr left a comment

Good catch.

nhooyr changed the title ~~change protocol on docs and logs, from http to ws~~ Change protocol in docs and logs from http to ws

nhooyr changed the base branch from master to dev

October 26, 2023 00:37


          Use ws:// over http:// in example logs

52721a9

nhooyr force-pushed the protocol branch from ccb8fb0 to 52721a9 Compare

October 26, 2023 00:39

nhooyr merged commit 22c9092 into nhooyr:dev

4 checks passed

KunalSin9h deleted the protocol branch

October 26, 2023 04:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment