Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary docker cleanup deletes the image you've just built #152

Open
regularfry opened this issue Mar 6, 2024 · 0 comments
Open

Unnecessary docker cleanup deletes the image you've just built #152

regularfry opened this issue Mar 6, 2024 · 0 comments

Comments

@regularfry
Copy link
Contributor

I don't think this line is right:

docker rmi --force "$(docker images | grep "<none>" | awk '{print $3}')" 2> /dev/null ||:

It looks like an attempt to clean up intermediate images. However, when I run it on podman on a fairly ordinary dockerfile, I don't get any <none> images. That means the rmi command looks like this:

docker rmi --force ''

That has the effect of deleting everything, including the image that's just been built.

I don't think we need that cleanup line, but I'm open to suggestions otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant