Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing Dockerfile.effective? #154

Open
regularfry opened this issue Mar 15, 2024 · 0 comments
Open

Committing Dockerfile.effective? #154

regularfry opened this issue Mar 15, 2024 · 0 comments

Comments

@regularfry
Copy link
Contributor

I usually try to follow a rule of not committing generated files. Here, though, we say:

6. Commit all changes to these files

- `infrastructure/images/cypress/Dockerfile`
- `infrastructure/images/cypress/Dockerfile.effective`
- `infrastructure/images/cypress/VERSION`
- `.tool-versions`

Dockerfile.effective is a generated file. Is that an accidental inclusion, or is there a use case I've forgotten about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant