-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus behaviour for buttons and anchors #751
Comments
This is expected behaviour at the moment - the reality is that in both these situations the button is still focused so the yellow highlight is shown correctly. You'll see the same behaviour if you look at the buttons on https://design-system.service.gov.uk/ This is now "fixable" by using https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible but I don't think this is something we would transition to lightly without significant research and possibly discussion with the govuk-frontend folks. Alas the feature's existence in web standards doesn't always mean it's been thoroughly considered from an accessibility and usability perspective. That's not a no, and I think we should consider it... Just need some evidence that it works well for people. |
Had a quick chat with someone from the GOV.UK design system team and they said:
|
Thanks for getting back quickly. I experimented a little (before you pointed out The behaviour of this change felt odd though as the highlight got lost and this would no doubt confuse people alternating between keyboard and mouse - myself included. From our point of view it looks like we'll have to wait for any future changes from you and GOV.UK . |
Bug Report
What is the issue?
The yellow focus indicator is visible after clicking on a button or an anchor.
What steps are required to reproduce the issue?
Mouse click
Move the mouse over the button, click and then move the mouse away. The yellow highlight is shown on the button.
![mouseFocusAndClick](https://user-images.githubusercontent.com/632231/123977188-ae829200-d9b6-11eb-9d32-edb02480c932.gif)
Keyboard
Tab onto the button, tap the enter key and leave. The yellow highlight is shown on the button.
![keyboardFocusAndEnter](https://user-images.githubusercontent.com/632231/123977249-bcd0ae00-d9b6-11eb-9478-25661d8f1a56.gif)
What was the environment where this issue occurred?
Is there anything else you think would be useful in recreating the issue?
We're aware this could be an accessibility feature and would like some input (no pun intended) on whether the behaviour is different in more recent versions or whether its the same?
The text was updated successfully, but these errors were encountered: