Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS, JavaScript and assets being imported from node_modules #191

Closed
chrimesdev opened this issue Apr 29, 2019 · 1 comment
Closed

CSS, JavaScript and assets being imported from node_modules #191

chrimesdev opened this issue Apr 29, 2019 · 1 comment

Comments

@chrimesdev
Copy link
Contributor

The CSS on the code snippet examples and the JavaScript/assets are being directly imported from the node_modules into pages. These should be compiled within the application via Sass/ES6 modules to give us more flexibility and customisation if we require.
@chrimesdev
Copy link
Contributor Author

The JavaScript on regular pages is also being imported directly from the NHS.UK frontend node_module folder <script src="/service-manual/nhsuk-frontend/nhsuk.min.js" defer></script>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrimesdev