Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default page template examples so default shows a heading inside a grid column #1969

Open
edwardhorsford opened this issue May 15, 2024 · 0 comments · May be fixed by #1975
Open

Update default page template examples so default shows a heading inside a grid column #1969

edwardhorsford opened this issue May 15, 2024 · 0 comments · May be fixed by #1975

Comments

@edwardhorsford
Copy link
Contributor

The default page template example does not include a grid row or column, and just has a heading inside of main.

I don't think services should ever do this. Pretty much all content should be within a 2/3 column - or at least one of the other grid columns. They should never have a heading inside main like that.

My suggestion would be to:

  • Update the default page template example to include a grid row and 2/3 column, with size l heading inside of it.
  • Update the customised page template example to include a more complex grid column arrangement.

Note the NHS example is pretty similar to the GOV.UK example. I've suggested on cross gov slack that it would be good for the default to change there too.

@edwardhorsford edwardhorsford linked a pull request May 27, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant