Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't close tasks in an event callback when using gRPC #559

Open
texasaggie97 opened this issue Apr 3, 2024 · 1 comment
Open

Can't close tasks in an event callback when using gRPC #559

texasaggie97 opened this issue Apr 3, 2024 · 1 comment

Comments

@texasaggie97
Copy link
Collaborator

test___done_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status and test___every_n_samples_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status fail when closing a task in an event callback.

This is supported when not using gRPC

@zhindes
Copy link
Collaborator

zhindes commented Apr 3, 2024

task.close() closes all open event handlers and then GrpcEventHandler.close() joins its event thread. When calling task.close from the event itself, the current thread is the event thread. A thread joining itself doesn't work so well. I think we just need a check for that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants