Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass-fail variant of burst_pattern is missing from nidigital API #1296

Closed
sbethur opened this issue Feb 27, 2020 · 0 comments · Fixed by #1336
Closed

Pass-fail variant of burst_pattern is missing from nidigital API #1296

sbethur opened this issue Feb 27, 2020 · 0 comments · Fixed by #1336

Comments

@sbethur
Copy link
Contributor

sbethur commented Feb 27, 2020

Description of issue

There are two variants of burst_pattern in LV and .NET APIs:

  1. Does not wait for pattern burst to complete
  2. Waits for pattern burst to complete and returns pass-fail results

Currently, to do what the 2nd variant in other APIs do, users have to call three methods:

burst_pattern()
get_site_pass_fail()
get_site_results_site_numbers()

..which is ugh. Also, 2nd variant is the majority use-case.

We should make burst_pattern more usable by making these changes:

  • Put these defaults --> wait_until_done=True, timeout=10. This will be done when Improve usability of nidigital API by making method args optional when applicable #1072 is fixed.
  • If wait_until_done=False, call niDigital_BurstPattern(wait_until_done=False) and return None.
  • If wait_until_done=True, call niDigital_BurstPattern(wait_until_done=True). Then call niDigital_GetSitePassFail() to get pass-fail results as list of bools. Then call niDigital_GetSiteResultsSiteNumbers() to get the sites corresponding to the results. Finally return the results as a dictionary of site (str): Pass-fail result (bool).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant