Update enum type names to match nidigital API in other ADEs

[sbethur]

Description of issue

Some enum type names in nimi-python nidigital API (e.g. DigitalState - In LV it is Pin State) may not match other ADEs (like LV and .NET). For the sake of usability and maintenance we should update enum names in nimi-python to match other ADEs.

[sbethur]

LabVIEW	.NET	Python (Current)	Python (Proposed)	Notes
PMU Aperture Time Units	PpmuApertureTimeUnits	'ApertureTimeUnits'	PPMUApertureTimeUnits	LV is inconsistent about having "PPMU" prefix for PPMU-based enums. In Python we should consistenly add the" PPMU" prefix
Bit Order	BitOrder	'BitOrder'
Conditional Jump Trigger ID	N/a	'ConditionalJumpTrigger'	ConditionalJumpTriggerID
Trigger Digital Edge - Edge	DigitalEdge	'DigitalEdge'		Not going to try and make the name consistent with LV since the name in LV isn't good
Pin State	PinState	'DigitalState'	PinState
Drive Format	DriveFormat	'DriveEdgeSetFormat'	DriveFormat
History RAM Cycles To Acquire	HistoryRamCycle	'HistoryRAMCyclesToAcquire'
N/a	HistoryRamTriggerType	'HistoryRAMTriggerType'
Measurement Mode	FrequencyMeasurementMode	'MeasurementMode'		This is unreleased enum. I propose we rename it to FrequencyMeasurementMode in all APIs
PPMU Current Limit Behavior	PpmuCurrentLimitBehavior	'PPMUCurrentLimitBehavior'
Measurement Type	PpmuMeasurementType	'PPMUMeasurementType'
Output Function	PpmuOutputFunction	'PPMUOutputFunction'
N/a	N/a	'PatternOpcodeEvent'
Selected Function	SelectedFunction	'SelectedFunction'
N/a	N/a	'SequencerFlag'
N/a	N/a	'SequencerRegister'
N/a	N/a	'SessionState'
Export Signal	SignalType	'Signal'	ExportSignal
Site Result Type	SiteResultType	'SiteResult'	SiteResultType
Data Mapping	SourceDataMapping	'SourceMemoryDataMapping'	DataMapping
TDR Endpoint Termination	TdrEndpointTermination	'TDREndpointTermination'
Trigger Terminals	N/a	'Terminal'	TriggerTerminal
Termination Mode	TerminationMode	'TerminationMode'
Time Set Edge Type	TimeSetEdge	'TimeSetEdge'	TimeSetEdgeType	For this one and for SiteResultType, the "Type" suffix is redundant, but that is what it is in LV. Should we be consistent with LV or should we get rid of the "Type" suffix?
N/a	TriggerType	'TriggerType'
Software Trigger	N/a	SoftwareTrigger'
Write Static Pin State	N/a	WriteStaticPinState'

[sbethur]

@marcoskirsch @mlopezleon

Please review my proposal above to update certain enum names.

[marcoskirsch]

I like your proposals.
Is SessionState in the public API? I'm surprised by that enum.

[sbethur]

SessionState is not in the public API. The list is for all enum types in internal metadata, across all levels of access.

I updated the internal metadata to remove SessionState from python metadata.

[mlopezleon]

My only comment is regarding the "type" suffix. I agree it is redundant, I would be ok removing it. If we do, what about TtriggerType?

[sbethur]

Hmm, good question. Apart from TriggerType, there's also HistoryRAMTriggerType and PPMUMeasurementType. Looking at these, Type suffix is not redundant is all the cases. To be consistent across all enum names and with LV, I'll leave the suffix in.