Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Table multi-delete + refactoring core libs #34

Merged
merged 5 commits into from
Dec 1, 2022
Merged

Conversation

mure
Copy link
Contributor

@mure mure commented Dec 1, 2022

What does this Pull Request accomplish?

  • Adds delete_tables method to remove multiple tables in one call
  • Refactors core.ApiError to be a Pydantic model so we can nest it in the delete partial success response
  • Adds response body de-serialization that can handle Union types
  • Adds wrappers around Uplink HTTP method decorators with naive typing to fix mypy errors and make client implementation simpler

What testing has been done?

  • Added automated tests for delete methods
  • Automated tag tests should hopefully cover ApiError refactor

@mure mure changed the title Table multi-delete + refactoring libs Table multi-delete + refactoring core libs Dec 1, 2022
@cameronwaterman cameronwaterman changed the title Table multi-delete + refactoring core libs feat: Table multi-delete + refactoring core libs Dec 1, 2022
@mure mure merged commit ebe9ce3 into master Dec 1, 2022
@mure mure deleted the delete-tables branch December 1, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants