Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make DataFrame and Spec clients compatible with SystemLink Client http configuration #61

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

santhoshramaraj
Copy link
Member

@santhoshramaraj santhoshramaraj commented Jun 12, 2024

What does this Pull Request accomplish?

Add JupyterHttpConfiguration as a fallback configuration for the HttpConfigurationManager. Allows the Clients to authenticate agnostic of the environment they're run from.

Why should this Pull Request be merged?

Enables SystemLink clients to adapt to supported run environments when using the default value for configuration arg like client = DataFrameClient()

What testing has been done?

Manual testing

  • Run https://github.com/ni/nisystemlink-clients-python/blob/master/examples/dataframe/export_data.py on the computer with SystemLink Client connected with an SLE server
  • KeyError occurs because JupyterHttpConfiguration is not available outside SLE
  • Update the DataFrameClient() to use core.HttpConfigurationManager.get_configuration() as the default configuration
  • Run the example, now, there should be no KeyError signifying that the client was created using the SystemLink client's HTTP Credentials

@santhoshramaraj santhoshramaraj added the enhancement New feature or request label Jun 12, 2024
@santhoshramaraj santhoshramaraj self-assigned this Jun 12, 2024
@santhoshramaraj santhoshramaraj changed the title feat: Extend HttpConfigurationManager to support JupyterHttpConfiguration feat: Make DataFrame and Spec clients compatible with SystemLink Client http configuration Jun 14, 2024
Copy link
Contributor

@mure mure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

nisystemlink/clients/core/_http_configuration_manager.py Outdated Show resolved Hide resolved
@spanglerco spanglerco merged commit 7954e14 into master Jun 18, 2024
6 checks passed
@spanglerco spanglerco deleted the users/sramaraj/jupyter-support-http-cfg-manager branch June 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easy to use the clients with SystemLink client application
3 participants