Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build nipkg as part of build pipeline #13

Merged
merged 1 commit into from Nov 13, 2018
Merged

Build nipkg as part of build pipeline #13

merged 1 commit into from Nov 13, 2018

Conversation

buckd
Copy link
Collaborator

@buckd buckd commented Nov 13, 2018

What does this Pull Request accomplish?

Allows nipkg to be built as part of the Chassis Timesync pipeline for release branches.

Why should this Pull Request be merged?

Testing the actual installers we produce and ship is vital. By building the nipkg installer as part of the build process, our automated test system can validate the exact binaries and installers customers will use.

What testing has been done?

  • Verified installer version matches version of release branch and that installer executes and places correct binaries in the correct location
  • Successfully added Chassis Timesync custom device to VeriStand 2018 after installation

@buckd buckd added the enhancement New feature or request label Nov 13, 2018
Copy link
Contributor

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch with the outdated license

@buckd buckd merged commit 8e39443 into master Nov 13, 2018
@buckd buckd deleted the dev/pkg-build branch November 13, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants