Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: configuration to disable update checking #4

Closed
SlimeDog opened this issue Jan 13, 2019 · 3 comments
Closed

Feature request: configuration to disable update checking #4

SlimeDog opened this issue Jan 13, 2019 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@SlimeDog
Copy link

HolographicExtension 1.10.4

Please add configuration option to disable update checks. I have my own homegrown automagical update checker, and I disable unnecessary (by my own standards) outgoing calls at the network level, using NetworkInterceptor. So console/log is spammed with

[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: java.io.IOException: Connect failed
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at me.lucko.networkinterceptor.interceptors.ProxySelectorInterceptor$LoggingSelector.select(ProxySelectorInterceptor.java:59)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1175)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/sun.net.www.protocol.http.HttpURLConnection$6.run(HttpURLConnection.java:1065)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/sun.net.www.protocol.http.HttpURLConnection$6.run(HttpURLConnection.java:1063)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.security.AccessController.doPrivileged(Native Method)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.security.AccessController.doPrivilegedWithCombiner(AccessController.java:793)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1062)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:177)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1581)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/sun.net.www.protocol.http.HttpURLConnection$9.run(HttpURLConnection.java:1501)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/sun.net.www.protocol.http.HttpURLConnection$9.run(HttpURLConnection.java:1499)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.security.AccessController.doPrivileged(Native Method)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.security.AccessController.doPrivilegedWithCombiner(AccessController.java:793)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:245)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at net.kitesoftware.holograms.updater.UpdateChecker.lambda$checkUpdates$0(UpdateChecker.java:38)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1692)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
[08:01:27] [ForkJoinPool.commonPool-worker-3/WARN]: 	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)
@Niall7459
Copy link
Owner

Sorry for this inconvenience. I'll get a config option added in the next release.

Thanks,

@Niall7459 Niall7459 added bug Something isn't working enhancement New feature or request labels Jan 13, 2019
@Niall7459
Copy link
Owner

Added,
d4c32f3
Enjoy

@SlimeDog
Copy link
Author

Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants