Send last message on client connect rather than broadcast #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a client joins the server, only that client needs the `last_message` and a broadcast to all is not really needed.
nicbou
reviewed
Aug 5, 2022
|
Ah that makes total sense. I assume that information didn't need to be up to date real time and 3 min sufficed, as it was not used in the interface. I'll close the PR, thanks for doing this project and for caring to improve the kafkaesque german bureaucracy. Please let me know how can I help on this front, enough tears spent in the Burgeramt already 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client joins the server, only that client needs the
last_messageand a broadcast to all is not really needed.This avoid processing in the server side + makes the response frequency/events more expectable if that makes sense.