Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force/advice user to enter mandatory fields when adding entry #300

Open
Heineken opened this issue Sep 19, 2019 · 2 comments
Open

Force/advice user to enter mandatory fields when adding entry #300

Heineken opened this issue Sep 19, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@Heineken
Copy link
Contributor

Heineken commented Sep 19, 2019

Problem:
The user can add an entry without description, but he cannot upload it and he doesn't know why.

Proposed fix (one or all of these):

  • If e.g. the description is required for an upload (to mundraub.org), a new entry shouldn't be accepted without a description.
  • There should be a warning.
  • There should be a message explaining why the upload is not possible

We're using [Polar.sh](https://polar.sh/niccokunzmann) so you can upvote and help fund this issue. We receive the funding once the issue is completed & confirmed by you. Thank you in advance for helping prioritize & fund our work. Fund with Polar
@niccokunzmann
Copy link
Owner

I would like a text to guide the user, because I would like to decouple the plant information from the API of the platform. So, when I create a plant, I would like to be in control over the information I provide at the moment or later. The platforms may differ in what they expect. So, I would like to be guided on what is required for upload.

Related Code:

public boolean hasRequiredFieldsFilled() {

There could be a second method named:
int getMessageToHelpFillTheRequiredFields()
which then returns the R.string.id for what to do.

This, then can be put into the GUI. Where would you like to see it?

@niccokunzmann niccokunzmann added the bug Something isn't working label Sep 20, 2019
@Heineken
Copy link
Contributor Author

Decouple means that validity for a platform shouldn't be checked on data entry but only before upload, right?
If so, either

  • the upload button should be greyed out and the message in red below
    or
  • the message should appear in a popup when pressing "upload"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants